urma: ubcore: fix the netns error path of the ueid update command · Pull Request !1130 · OpenCloudOS/OpenCloudOS-Kernel

## Problem

`ubcore_update_ueid()` resolves the net namespace passed by the caller with
`get_net_ns_by_fd()` and then requires it to be accessible from the device. Both
failures share a single branch, but the branch only handles the first one
correctly.

`get_net_ns_by_fd()` returns either a valid `struct net *` or an `ERR_PTR`.
Checking it with `IS_ERR(net) || !ubcore_dev_accessible(dev, net)` mixes the two
cases: when the namespace is valid but not accessible, `PTR_ERR()` is applied to
a valid pointer and its result is returned as the status. That is the truncated
address of the pointer rather than an errno, so the command reports a
meaningless value instead of `-EPERM`. If the truncated value happens to be
zero, the netlink start callback reports success while `cb->args[0]` is still
unset (`__netlink_dump_start()` zeroes the callback), and the dump callback
hands a NULL context to `ubcore_update_uvs_eid_ret()`, which dereferences it.

The same branch also drops the namespace reference taken by
`get_net_ns_by_fd()`, so every rejected request leaks one net namespace
reference.

Both `ubcore_add_eid_start` and `ubcore_delete_eid_start` reach this code; the
other error paths in the function already call `put_net()`.

## Fix

Separate the two failures: return `PTR_ERR()` only for an invalid pointer,
return `-EPERM` for a valid but inaccessible namespace, and release the
reference in the latter case.

## Verification

- `scripts/checkpatch.pl --no-signoff --strict`: 0 errors, 0 warnings.
- arm64 build (`CONFIG_UB=y` + `CONFIG_UB_URMA=y`, target `drivers/ub/urma/ubcore/`, Bootlin aarch64 gcc 15.3.0, `W=1`): baseline and patched trees both build with exit 0, all 24 objects force-recompiled in both cases, and both show the same 5 pre-existing `-Wmissing-prototypes` warnings in `ubcore_connect_adapter.c`; no new diagnostics.
- Not run: runtime regression. No UB hardware is available in the development environment; reaching the path requires a generic netlink request with a namespace fd that is valid but not exposed to the device.

类型	指派人员	状态
审查	zoucao Huang Cun Jianping Liu	已完成 (0/0人)
测试	Jianping Liu	已完成 (0/0人)

GVPOpenCloudOS / OpenCloudOS-Kernel

搜索帮助

GVP OpenCloudOS / OpenCloudOS-Kernel