urma: ubcore: undo the old jetty binding when the driver rejects the update · Pull Request !1128 · OpenCloudOS/OpenCloudOS-Kernel

## Problem

`ubcore_set_jetty_opt()` drops the software reference of the binding being
replaced with `ubcore_jetty_opt_put_old()` before it hands the request to the
driver: it decrements the `use_cnt` of the JFC/JFR bound to the jetty, or
removes the jetty from its JTG.

If `dev->ops->set_jetty_opt()` fails, the function returns the driver error
without restoring that reference, while `jetty_cfg` still points at the old
object and the hardware is unchanged. The JFC/JFR is left with a `use_cnt` one
lower than the number of jetties actually bound to it.

`ubcore_delete_jfc()` and `ubcore_delete_jfr()` refuse to destroy an object
whose `use_cnt` is not zero, so a failed binding update lets userspace delete a
JFC/JFR that a jetty is still bound to. `ubcore_free_jetty()` then runs
`atomic_dec(&recv_jfc->use_cnt)` on the freed object, and the jetty keeps
reading a stale `recv_jfc`/`jfr` pointer.

The `ubcore_set_options_common()` failure at the end of the same function
already restores the old binding through `ubcore_jetty_opt_rollback_old()`; the
driver failure path is the only one that does not.

Reachable from userspace through the jetty option command in
`uburma_cmd_modify_jetty()`, which forwards a user supplied JFC/JFR/JTG handle
to this function.

## Fix

Call `ubcore_jetty_opt_rollback_old()` when the driver rejects the update, so
the reference taken away by `ubcore_jetty_opt_put_old()` is given back and the
software state keeps matching the hardware.

Only the driver error path changes; a successful update is unaffected.

## Verification

- `scripts/checkpatch.pl --no-signoff --strict`: 0 errors, 0 warnings.
- arm64 build (`CONFIG_UB=y` + `CONFIG_UB_URMA=y`, target `drivers/ub/urma/ubcore/`, Bootlin aarch64 gcc 15.3.0, `W=1`): baseline and patched trees both build with exit 0, all 24 objects force-recompiled in both cases, and both show the same 5 pre-existing `-Wmissing-prototypes` warnings in `ubcore_connect_adapter.c`; no new diagnostics.
- Not run: runtime regression. No UB hardware is available in the development environment, and reaching the changed path requires a driver level failure.

类型	指派人员	状态
审查	zoucao Huang Cun Jianping Liu	已完成 (0/0人)
测试	Jianping Liu	已完成 (0/0人)

GVPOpenCloudOS / OpenCloudOS-Kernel

搜索帮助

GVP OpenCloudOS / OpenCloudOS-Kernel