diff --git a/plugins/os-monitor/collector/net/flow.go b/plugins/os-monitor/collector/net/flow.go index fd6a2a11cb5978f1839804ecd192b45b53f71075..d47b394d4ecb9660c596cba3d7a70a0f2ce05b50 100644 --- a/plugins/os-monitor/collector/net/flow.go +++ b/plugins/os-monitor/collector/net/flow.go @@ -174,7 +174,6 @@ func (f *FlowTask) readDevStatDmi(device string, dmi string) (uint64, error) { } ok, content, err := utils.ReadFileWithDefaultRet(path, "") if !ok { - fmt.Println(err) return 0, err } return strconv.ParseUint(strings.TrimSpace(content), 10, 64) diff --git a/plugins/os-monitor/main.go b/plugins/os-monitor/main.go index 0dbbcd4bae2eab93fe04246756ebae1c8aee3ce1..4b60cc29034e86be7e8d630386651a124586c9fb 100644 --- a/plugins/os-monitor/main.go +++ b/plugins/os-monitor/main.go @@ -17,19 +17,16 @@ import ( func setWorkingDir() { ex, err := os.Executable() if err != nil { - fmt.Println("Failed to get program path") + fmt.Fprintln(os.Stderr, "Failed to get program path") os.Exit(1) } exPath := filepath.Dir(ex) err = os.Chdir(exPath) if err != nil { - fmt.Println("Failed to change working dir") + fmt.Fprintln(os.Stderr, "Failed to change working dir") os.Exit(1) } - - currentPath, _ := os.Getwd() - fmt.Println(currentPath) } // main 是 os-monitor 插件的入口: diff --git a/plugins/os-monitor/worker.go b/plugins/os-monitor/worker.go index eb75f71db9dd3ba1ee0cb7c30823f65a176143a0..4a35b4941302b54ff70cc578646f5ae790095855 100644 --- a/plugins/os-monitor/worker.go +++ b/plugins/os-monitor/worker.go @@ -1,7 +1,6 @@ package main import ( - "fmt" "time" "github.com/robfig/cron/v3" @@ -106,13 +105,6 @@ func (w *Worker) pushMetrics(metrics []*agent.Metric) error { if len(metrics) == 0 { return nil } - names := map[string]bool{} - for _, metric := range metrics { - names[metric.Name] = true - } - for name, _ := range names { - fmt.Println(name) - } metricData := &agent.MetricsData{ TsNs: uint64(time.Now().UnixNano()), diff --git a/plugins/sample/main.go b/plugins/sample/main.go index 05420e4cab2cc862c5c8b99f00551d5a1af180a0..fc8893f67ee43655f922ecca26a1159e090b1366 100644 --- a/plugins/sample/main.go +++ b/plugins/sample/main.go @@ -37,5 +37,4 @@ func main() { fmt.Printf("failed to push metrics data, error: %v\n", err) return } - fmt.Println("pushed metrics data successfully") } diff --git a/plugins/sysinfo-collector/rpm/rpms.go b/plugins/sysinfo-collector/rpm/rpms.go index 5ab9349547673eb78dc804eb9303946660f56a22..92e5083ee8b4289e58ec25645673cd4c9368b152 100644 --- a/plugins/sysinfo-collector/rpm/rpms.go +++ b/plugins/sysinfo-collector/rpm/rpms.go @@ -35,11 +35,7 @@ func getRpmPackages() ([]*pb.Metric, error) { var res []*pb.Metric select { case <-ctx.Done(): // 超时,可能是机器rpm文件损坏 - if err := cmd.Process.Kill(); err != nil { - fmt.Println("failed to kill 'rpm -qa'") - } else { - fmt.Println("Process killed") - } + _ = cmd.Process.Kill() return nil, fmt.Errorf("failed to run rpm cmd, timeout") case err := <-done: if err != nil { @@ -49,7 +45,7 @@ func getRpmPackages() ([]*pb.Metric, error) { output := outBuffer.String() pattern, err := regexp.Compile(`\[(.*?)\]--\[(.*?)\]--\[(.*?)\]--\[(.*?)\]\n`) if err != nil { - fmt.Println("failed to compile regexp") + return nil, fmt.Errorf("failed to compile regexp: %w", err) } pkgs := pattern.FindAllStringSubmatch(output, -1) for _, pkg := range pkgs {